Re: Few untranslated error messages in OAuth
Álvaro Herrera <alvherre@kurilemu.de>
From: Álvaro Herrera <alvherre@kurilemu.de>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-13T12:32:27Z
Lists: pgsql-hackers
On 2025-Nov-13, Daniel Gustafsson wrote:
> I was pondering that since auth error messages in backend libpq does this, but
> since we don't use gettext_noop anywhere else in frontend libpq today it makes
> sense to go with libpq_gettext and update the docs instead.
>
> Unless you, who has more translation/nls insights than me, feel strongly about
> gettext_noop I'll go ahead with the current patch.
gettext_noop() does something completely different from libpq_gettext(),
and the more I think about this, the more I think doing libpq_gettext()
is the wrong thing. I can give it a shot if you want.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Update: super-fast reaction on the Postgres bugs mailing list. The report
was acknowledged [...], and a fix is under discussion.
The wonders of open-source !"
https://twitter.com/gunnarmorling/status/1596080409259003906
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
libpq: Align oauth_json_set_error() with other NLS patterns
- 7a15cff1f111 18.2 landed
- f7fbd02d32c4 19 (unreleased) landed
-
libpq-oauth: Don't translate internal errors
- aac25567fec1 18.2 landed
- 301a1dcf00c8 19 (unreleased) landed
-
libpq: Add missing OAuth translations
- 169ff4ca930b 18.2 landed
- ea3370b18ebe 19 (unreleased) landed