Horton
Menu

Re: Few untranslated error messages in OAuth

Álvaro Herrera <alvherre@kurilemu.de>

View thread
From: Álvaro Herrera <alvherre@kurilemu.de>
To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-13T08:13:40Z
Lists: pgsql-hackers 
On 2025-Nov-13, Zhijie Hou (Fujitsu) wrote:

> Hi,
> 
> During testing of libpq, I noticed several error messages not processed by
> libpq_gettext, resulting in their exclusion from *.pot files. The attached patch
> wraps these messages.

Yeah, this roughly makes sense.  I think the documentation for errctx in
async_ctx needs to be updated though, because currently it says "it'll
be translated for you" but this patch makes it the other way around (it
must come translated).

Alternatively, we could mark the strings with gettext_noop(), which only
adds the messages to the catalog without translating them; so the
responsibility of translating them would remain where it is today.  This
might be easier.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"No tengo por qué estar de acuerdo con lo que pienso"
                             (Carlos Caszeli)

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. libpq: Align oauth_json_set_error() with other NLS patterns

  2. libpq-oauth: Don't translate internal errors

  3. libpq: Add missing OAuth translations