Horton

Re: Suggestion to add --continue-client-on-abort option to pgbench

Yugo Nagata <nagata@sraoss.co.jp>

View thread
From: Yugo Nagata <nagata@sraoss.co.jp>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>, Rintaro Ikeda <ikedarintarof@oss.nttdata.com>, Jakub Wartak <jakub.wartak@enterprisedb.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, "slpmcf@gmail.com" <slpmcf@gmail.com>, "boekewurm+postgres@gmail.com" <boekewurm+postgres@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Srinath Reddy Sadipiralla <srinath2133@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>
Date: 2025-11-12T07:47:03Z
Lists: pgsql-hackers 
On Wed, 12 Nov 2025 00:22:38 +0900
Fujii Masao <masao.fujii@gmail.com> wrote:

> On Tue, Nov 11, 2025 at 11:41 AM Chao Li <li.evan.chao@gmail.com> wrote:
> > I am also debugging the patch for the other purpose when I saw your email, so I tried to reproduce the problem with your script.
> >
> > I think in master branch, we can simply fix the problem by calling discardAvailableResults(st) before discardUntilSync(st), like this:
> 
> This change doesn't seem to fix the issue. If the custom script includes
> many \syncpipeline commands, the assertion failure can still occur. No?

Yes. discardAvailableResults() does not discard all syncs, just until
NULL following the first sync, in pipeline mode without a connection failure.

Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>