Horton

Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement

Álvaro Herrera <alvherre@kurilemu.de>

View thread
From: Álvaro Herrera <alvherre@kurilemu.de>
To: Manni Wood <manni.wood@enterprisedb.com>
Cc: Jim Jones <jim.jones@uni-muenster.de>, Nishant Sharma <nishant.sharma@enterprisedb.com>, pgsql-hackers@postgresql.org
Date: 2025-11-10T11:27:03Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add infrastructure for pg_get_*_ddl functions

  2. Add pg_get_tablespace_ddl() function

  3. Split out innards of pg_tablespace_location()

  4. Remove spclocation field from pg_tablespace

On 2025-Nov-08, Manni Wood wrote:

> However, I see that this
> https://cirrus-ci.com/task/6437176629526528?logs=clone#L214 checks out a
> specific commit on a specific branch:
> 
> "Checked out db131410131cb6a60f074213b0e7aaaa15d72f87 on cf/6175 branch."
> 
> My clone of postgres (which is presumably shallow?) does not show that
> branch, not even with "git branch -r".

Yeah, these branches used by CI are made up on the spot and aren't
propagated out of that repository.  You can add a "remote" to your
existing clone,

git remote add cfbot https://github.com/postgresql-cfbot/postgresql.git

and then you can see the branches it creates and `git switch` to them.
Do mind that they are ephemeral, and for this thread they only contain
the patches you submitted yourself; really, this is only useful if
you're going to review other people's patches, and even then it might
still be better to use the patches from the mailing list (which is where
cfbot itself grabs them from anyway).

You should definitely be reviewing other people's patches, though, not
just because it's valuable for the community as a whole to have an
additional pair of eyes on them, but also because they can teach you
many things.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Oh, great altar of passive entertainment, bestow upon me thy discordant images
at such speed as to render linear thought impossible" (Calvin a la TV)