Horton

Re: Reorganize GUC structs

Álvaro Herrera <alvherre@kurilemu.de>

View thread View on postgr.es
From: Álvaro Herrera <alvherre@kurilemu.de>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Heikki Linnakangas <hlinnaka@iki.fi>, John Naylor <johncnaylorls@gmail.com>
Date: 2025-11-07T15:53:26Z
Lists: pgsql-hackers 
On 2025-Nov-07, Peter Eisentraut wrote:

> Actually, the ", " already exists in the message catalog, so adding a
> comment here might confuse the other site.

This one?
#: replication/logical/relation.c:245
#, c-format
msgid ", \"%s\""
msgstr ", »%s«"

It's different.  (And warrants a comment too, IMO)

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"La rebeldía es la virtud original del hombre" (Arthur Schopenhauer)

Commits

  1. Remove extraneous newlines from guc_parameters.dat

  2. Fix NLS for incorrect GUC enum value hint message

  3. Clean up qsort comparison function for GUC entries

  4. Sort guc_parameters.dat alphabetically by name

  5. Reorganize GUC structs

  6. Change config_generic.vartype to be initialized at compile time

  7. Use designated initializers for guc_tables

  8. Change reset_extra into a config_generic common field

  9. Add some const qualifiers

  10. Modernize some for loops