Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement

Álvaro Herrera <alvherre@kurilemu.de>

From: Álvaro Herrera <alvherre@kurilemu.de>

To: Nishant Sharma <nishant.sharma@enterprisedb.com>

Cc: Jim Jones <jim.jones@uni-muenster.de>, Manni Wood <manni.wood@enterprisedb.com>, pgsql-hackers@postgresql.org

Date: 2025-11-07T09:58:31Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add infrastructure for pg_get_*_ddl functions
- 4881981f9202 19 (unreleased) landed
Add pg_get_tablespace_ddl() function
- b99fd9fd7f36 19 (unreleased) landed
Split out innards of pg_tablespace_location()
- 877a024902a7 19 (unreleased) landed
Remove spclocation field from pg_tablespace
- 16d8e594acd9 9.2.0 cited

On 2025-Nov-05, Nishant Sharma wrote:

> Thanks Álvaro for the review comments on v4!
> 
> PFA, v5 patch set. I have included all your review comments.

Great, thanks.

I think adding the get_tablespace_location_string function in
ruleutils.c makes little sense -- I would say it belongs in
src/backend/catalog/pg_tablespace.c.  Since this file happens not to
exist, you can create it.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Someone said that it is at least an order of magnitude more work to do
production software than a prototype. I think he is wrong by at least
an order of magnitude."                              (Brian Kernighan)