Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. What I've done:

  1. Remove an unnecessary blank line on the PQisBusy() comments

    Yugo Nagata <nagata@sraoss.co.jp> — 2025-10-23T11:02:03Z

    Hi,

I’ve attached a very trivial patch that removes an unnecessary line
after the comments on PQisBusy(), just for consistency with the
surrounding code.

Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>

  2. Re: Remove an unnecessary blank line on the PQisBusy() comments

    Nathan Bossart <nathandbossart@gmail.com> — 2025-10-23T15:11:26Z

    On Thu, Oct 23, 2025 at 08:02:03PM +0900, Yugo Nagata wrote:
> I’ve attached a very trivial patch that removes an unnecessary line
> after the comments on PQisBusy(), just for consistency with the
> surrounding code.

Given this line has been there for 28 years (commit edbd513) and isn't
hurting anything, I don't see a strong need to change it.

-- 
nathan

  3. Re: Remove an unnecessary blank line on the PQisBusy() comments

    Euler Taveira <euler@eulerto.com> — 2025-10-23T15:19:03Z

    On Thu, Oct 23, 2025, at 12:11 PM, Nathan Bossart wrote:
> On Thu, Oct 23, 2025 at 08:02:03PM +0900, Yugo Nagata wrote:
>> I’ve attached a very trivial patch that removes an unnecessary line
>> after the comments on PQisBusy(), just for consistency with the
>> surrounding code.
>
> Given this line has been there for 28 years (commit edbd513) and isn't
> hurting anything, I don't see a strong need to change it.
>

In this same file there are other cases of blank line after comment and before
function definition. If, in the future, we have an automated tool (pgindent?)
that removes such blank line(s) after comment and before function definition, I
would say fix it. That's not the case; I would leave it alone.


-- 
Euler Taveira
EDB   https://www.enterprisedb.com/

  4. Re: Remove an unnecessary blank line on the PQisBusy() comments

    Yugo Nagata <nagata@sraoss.co.jp> — 2025-10-24T01:35:51Z

    On Thu, 23 Oct 2025 12:19:03 -0300
"Euler Taveira" <euler@eulerto.com> wrote:

> On Thu, Oct 23, 2025, at 12:11 PM, Nathan Bossart wrote:
> > On Thu, Oct 23, 2025 at 08:02:03PM +0900, Yugo Nagata wrote:
> >> I’ve attached a very trivial patch that removes an unnecessary line
> >> after the comments on PQisBusy(), just for consistency with the
> >> surrounding code.
> >
> > Given this line has been there for 28 years (commit edbd513) and isn't
> > hurting anything, I don't see a strong need to change it.
> >
> 
> In this same file there are other cases of blank line after comment and before
> function definition. If, in the future, we have an automated tool (pgindent?)
> that removes such blank line(s) after comment and before function definition, I
> would say fix it. That's not the case; I would leave it alone.

Thank you for taking a look at it.
I was just wondering about it, and agree that there's no need to remove it at
this point since it’s harmless.

Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>