Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options

Tatsuo Ishii <ishii@postgresql.org>

From: Tatsuo Ishii <ishii@postgresql.org>

To: dgrowleyml@gmail.com, li.evan.chao@gmail.com

Cc: tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, pramsey@cleverelephant.ca, ojford@gmail.com, peter@eisentraut.org, krasiyan@gmail.com, vik@postgresfriends.org, andrew@tao11.riddles.org.uk, david@fetter.org

Date: 2025-10-23T02:06:59Z

Lists: pgsql-hackers

>> On Mon, 20 Oct 2025 at 16:59, Tatsuo Ishii <ishii@postgresql.org> wrote:
>>>
>>> > A very trivial commit:
>>> >
>>> > ```
>>> > +     else
>>> > +
>>> > +             /*
>>> > +              * For other cases we have no idea what position of row callers would
>>> > +              * fetch next time. Also for relpos < 0 case (we go backward), we
>>> > +              * cannot set mark either. For those cases we always set mark at 0.
>>> > +              */
>>> > +             mark_pos = 0;
>>> > ```
>>> >
>>> > The empty line after “else” is not needed.
>>>
>>> That was added by pgindent.
>> 
>> If it's written down somewhere, I can't find it, but the rule we
>> normally follow here is; don't use braces if the code block has a
>> single statement without any comments that appear on a separate line.
>> Otherwise, use braces.
> 
> Oh ok, I didn't know that.
> 
>> Since your comments are not on the same line as the statement, it
>> should have braces. I imagine that's why pgindent is "acting weird".
> 
> Attached is a trivial patch to follow the rule.

Patch pushed. Thanks.
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp