Horton

Re: simplifying grammar for ALTER CONSTRAINT .. SET [NO] INHERIT

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Álvaro Herrera <alvherre@alvh.no-ip.org>
To: Suraj Kharage <suraj.kharage@enterprisedb.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-03-27T08:27:00Z
Lists: pgsql-hackers 
On 2025-Mar-26, Suraj Kharage wrote:

>  Yes, I agree. As Peter said, it is now inline with other commands.
> 
> I have reviewed the patch and it looks good to me.

Thanks for reviewing!

> Since we are removing the SET keyword, how about removing that from the
> below comment as well.
> 
> /*
> * Propagate the change to children.  For SET NO INHERIT, we don't
> * recursively affect children, just the immediate level.
> */
> 
> This is the comment from ATExecAlterConstrInheritability().

Ah right.  Fixed that and pushed.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

Commits

  1. Simplify syntax for ALTER TABLE ALTER CONSTRAINT NO INHERIT

  2. Add ALTER TABLE ... ALTER CONSTRAINT ... SET [NO] INHERIT