Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Unify wording of user-facing "row security" messages.

  2. pg_dump, pg_dumpall, pg_restore: Add --no-policies option.

  1. Unify a recently-added inconsisnt message

    Kyotaro Horiguchi <horikyota.ntt@gmail.com> — 2025-03-17T04:53:05Z

    Subject: Unify a recent-added inconsisnt message

Hello.

I noticed that the recent commit cd3c45125d2 introduced the following
three inconsistent messages at the same time:

pg_dump.c:
+       printf(_("  --no-policies                do not dump row security policies\n"));

pg_dumpall.c:
+       printf(_("  --no-policies                do not dump row security policies\n"));

pg_restore.c:
+       printf(_("  --no-policies                do not restore row level security policies\n"));

The existing user-facing messages commonly use "row security".
Therefore, I believe the newly introduced message should follow the
same wording for consistency.

Please find the attached patch that updates the inconsistent message.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

  2. Re: Unify a recently-added inconsisnt message

    Tom Lane <tgl@sss.pgh.pa.us> — 2025-03-17T16:55:21Z

    Kyotaro Horiguchi <horikyota.ntt@gmail.com> writes:
> I noticed that the recent commit cd3c45125d2 introduced the following
> three inconsistent messages at the same time:
> pg_dump.c:
> +       printf(_("  --no-policies                do not dump row security policies\n"));
> pg_dumpall.c:
> +       printf(_("  --no-policies                do not dump row security policies\n"));
> pg_restore.c:
> +       printf(_("  --no-policies                do not restore row level security policies\n"));

Ooops :-(.  I should have caught that during review.

> Please find the attached patch that updates the inconsistent message.

Pushed, thanks for noticing it.

			regards, tom lane