Re: refactor AlterDomainAddConstraint (alter domain add constraint)
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: jian he <jian.universality@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2025-03-10T18:37:19Z
Lists: pgsql-hackers
Hello, On 2025-Jan-15, jian he wrote: > we cannot error out AlterDomainAddConstraint for cases like ALTER > DOMAIN ADD CHECK NO INHERIT. > because "NO INHERIT" is actually a separate Constraint Node, and > AlterDomainAddConstraint > can only handle one Constraint node. I had forgotten this thread, and I ended up implementing a different solution for this issue, which I just posted at https://postgr.es/m/202503101758.ipn3g64twfye@alvherre.pgsql I like my patch better than this approach because it allows us to solve the same problem as it appears in other parts of the grammar, and also because it avoids the bit fiddling which is harder to maintain later on. If you'd care to have a look at it, I'd appreciate it. Thanks -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
Commits
-
Fix bogus grammar for a CREATE CONSTRAINT TRIGGER error
- 87251e114967 19 (unreleased) cited
-
Remove dead code
- 7407b2d48cf3 18.0 landed