Inconsistent GUC descriptions

Kyotaro Horiguchi <horikyota.ntt@gmail.com>

From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>

To: pgsql-hackers@lists.postgresql.org

Date: 2025-02-20T05:08:39Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Improve errdetail message added by ac0e33136a.
- 7da344b9f84f 18.0 landed
Invalidate inactive replication slots.
- ac0e33136abc 18.0 cited

Attachments

0001-Align-a-recently-added-message-with-an-existing-one.patch (text/x-patch)

Hello, (this mail is not a duplicate sent by mistake.)

The recent commit ac0e33136ab introduced the following message:

+	GUC_check_errdetail("The value of \"%s\" must be set to 0 during binary upgrade mode.",

However, the existing message for the same situation is written
without "The value of" at the beginning. In addition, all existing
messages following the "%s must be set to" pattern omit this phrase.

Therefore, I believe the initial part of the new message should be
removed for consistency. The attached patch makes this adjustment.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center