Horton

Re: Elimination of the repetitive code at the SLRU bootstrap functions.

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread
From: Álvaro Herrera <alvherre@alvh.no-ip.org>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: Evgeny Voropaev <evgeny.voropaev@tantorlabs.com>, pgsql-hackers@postgresql.org
Date: 2025-02-13T13:21:33Z
Lists: pgsql-hackers 
On 2025-Feb-13, Aleksander Alekseev wrote:

> Since BootStrapSlruPage() is the only caller of ZeroPage() it seems to
> me that it merely wastes space in SlruCtlData. On top of that I'm not
> 100% sure if all the supported platforms have C99 compilers with
> designated initializers support.

They do -- we use them quite extensively nowadays.

> Wouldn't it be simpler to pass the callback straight to
> BootStrapSlruPage()?

Yeah, maybe this would be easier.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Just treat us the way you want to be treated + some extra allowance
 for ignorance."                                    (Michael Brusser)