Horton

Re: TRAP: failed Assert("outerPlan != NULL") in postgres_fdw.c

Álvaro Herrera <alvherre@kurilemu.de>

View thread
From: Álvaro Herrera <alvherre@kurilemu.de>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, Michael Paquier <michael@paquier.xyz>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>, kristianlejao@gmail.com
Date: 2025-09-26T13:34:38Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix EvalPlanQual handling of foreign/custom joins in ExecScanFetch.

On 2025-Sep-24, Etsuro Fujita wrote:

> I took a quick glance at the patch.  My initial comment is: it only
> includes the test case discussed here, but I think it's a good idea to
> add more cases in it (that exercise code paths in
> postgresRecheckForeignScan), as I mentioned upthread.  What do you
> think about that?  If no objections, I'd like to update it to include
> such cases.

I would like to suggest a different approach: because this patch is
known to fix a server crash in a known case, it would be better to get
the fix (and its corresponding test) pushed as is without further delay.
Additional tests are an excellent idea, but I think we shouldn't make
this patch wait for them.  If further fixes are deemed necessary for
those other (thus far hypothetical) tests, we can still make them
afterwards.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/