Horton

Thread

Commits

  1. pgbench: Remove unused argument from create_sql_command().

  2. SQL commands in pgbench scripts are now ended by semicolons, not newlines.

  1. pgbench: remove an unused function argument

    Yugo Nagata <nagata@sraoss.co.jp> — 2025-09-17T02:28:14Z

    Hi,

I've attached a patch that removes an unused argument from
create_sql_command() in pgbench.c.

This originates from commit 68ab8e8ba4a4, which split process_commands()
into process_sql_command() (the predecessor of create_sql_command())
and process_backslash_command().

Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>

  2. Re: pgbench: remove an unused function argument

    Steven Niu <niushiji@gmail.com> — 2025-09-17T08:25:35Z

    Looks good to me.

Best Regards,
Steven
________________________________
From: Yugo Nagata <nagata@sraoss.co.jp>
Sent: Wednesday, September 17, 2025 10:28
To: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: pgbench: remove an unused function argument

Hi,

I've attached a patch that removes an unused argument from
create_sql_command() in pgbench.c.

This originates from commit 68ab8e8ba4a4, which split process_commands()
into process_sql_command() (the predecessor of create_sql_command())
and process_backslash_command().

Regards,
Yugo Nagata

--
Yugo Nagata <nagata@sraoss.co.jp>

  3. Re: pgbench: remove an unused function argument

    Fujii Masao <masao.fujii@gmail.com> — 2025-09-17T13:31:03Z

    On Wed, Sep 17, 2025 at 5:25 PM Steven Niu <niushiji@gmail.com> wrote:
> I've attached a patch that removes an unused argument from
> create_sql_command() in pgbench.c.

LGTM. Barring any objection, I will commit the patch.

Regards,

-- 
Fujii Masao

  4. Re: pgbench: remove an unused function argument

    Fujii Masao <masao.fujii@gmail.com> — 2025-09-18T02:23:52Z

    On Wed, Sep 17, 2025 at 10:31 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Wed, Sep 17, 2025 at 5:25 PM Steven Niu <niushiji@gmail.com> wrote:
> > I've attached a patch that removes an unused argument from
> > create_sql_command() in pgbench.c.
>
> LGTM. Barring any objection, I will commit the patch.

I've pushed the patch. Thanks!

Regards,

-- 
Fujii Masao