Horton

Re: BUG #18960: Mistake in test test_simple_pipeline (libpq_pipeline.c)

Álvaro Herrera <alvherre@kurilemu.de>

View thread
From: Álvaro Herrera <alvherre@kurilemu.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: d.kovalenko@postgrespro.ru, pgsql-bugs@lists.postgresql.org
Date: 2025-09-03T12:28:30Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Make libpq_pipeline.c shorter and more uniform via helper functions.

  2. pg_dump: Allow pg_dump to dump the statistics for foreign tables.

On 2025-Jun-21, Tom Lane wrote:

> Here's a shot at improving matters.  I also made an effort
> at cleaning up memory leaks in libpq_pipeline.c, although
> that's surely neatnik-ism not anything meaningful.

Yeah, the code looks much better this way.  I thought it was a bit odd
that a function called confirm_result_status() would actually consume
said status.  Would it be better as
  consume_result_status(PGconn *conn, ExecStatusType expected)
?

I think the patch is a clear improvement regardless.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"World domination is proceeding according to plan"        (Andrew Morton)