Horton

Re: pgsql: Move SQL-callable code related to multixacts into its own file

Álvaro Herrera <alvherre@kurilemu.de>

View thread View on postgr.es
From: Álvaro Herrera <alvherre@kurilemu.de>
To: Andres Freund <andres@anarazel.de>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>, pgsql-committers@lists.postgresql.org
Date: 2025-08-19T15:17:52Z
Lists: pgsql-hackers 
On 2025-Aug-19, Andres Freund wrote:

> On 2025-08-19 14:01:52 +0000, Bertrand Drouvot wrote:

> > That said, autoconf does not report the issue, and that's because test/modules
> > is missing in src/Makefile. Is there any reasons for that? If not, the attached
> > fix it.
> 
> That can't be the reason - it's reached from src/test/Makefile
> 
> > SUBDIRS = perl postmaster regress isolation modules authentication recovery subscription

Yeah, I'm not on board with making changes to the makefiles, because
AFAIR the current arrangement is purposefully what is is.  I did
discover that my build script does "make install ; make -C contrib
install", which means src/test/modules is not built.  But that's a local
fix for me.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
<inflex> really, I see PHP as like a strange amalgamation of C, Perl, Shell
<crab> inflex: you know that "amalgam" means "mixture with mercury",
       more or less, right?
<crab> i.e., "deadly poison"

Commits

  1. Avoid including commands/dbcommands.h in so many places

  2. Remove unneeded header declarations in multixact.c

  3. Move SQL-callable code related to multixacts into its own file

  4. Create a syscache for pg_database-indexed-by-oid, and make use of it