Re: Doc: Add note for running ANALYZE after ALTER TABLE ... SET EXPRESSION
Yugo Nagata <nagata@sraoss.co.jp>
From: Yugo Nagata <nagata@sraoss.co.jp>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2025-08-06T06:43:58Z
Lists: pgsql-hackers
Attachments
- for17_fix_doc_alter_table_set_expression.patch (text/x-diff) patch
On Wed, 6 Aug 2025 13:20:18 +0900 Fujii Masao <masao.fujii@gmail.com> wrote: > On Tue, Aug 5, 2025 at 10:09 AM Yugo Nagata <nagata@sraoss.co.jp> wrote: > > Thank you for looking at it. I overlooked that virtual generated columns > > don't have statistics currently (I'm working on this at [1], though). > > > > Your suggestion makes sense, so I've attached an updated patch. > > I also mentioned virtual generated column in the description > > of SET DATA TYPE. > Thanks for updating the patch! > > As for back-patching, ANALYZE recommendation for SET EXPRESSION should > be back-patched to v17, where that feature was introduced? Similarly, > the note about virtual generated columns should go into v18, > since that's when they were added? Yes. I believe the back-patching would be better to both v17 and v18. I've attached a patch for v17. Regards, Yugo Nagata -- Yugo Nagata <nagata@sraoss.co.jp>
Commits
-
doc: Recommend ANALYZE after ALTER TABLE ... SET EXPRESSION AS.
- 753177604b33 17.6 landed
- 3e65e77f7666 18.0 landed
- 0b6aea03843d 19 (unreleased) landed