Re: fix ancient typo in transformRelOptions()
Álvaro Herrera <alvherre@kurilemu.de>
From: Álvaro Herrera <alvherre@kurilemu.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers@postgresql.org
Date: 2025-08-05T22:14:44Z
Lists: pgsql-hackers
On 2025-Aug-05, Tom Lane wrote: > =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes: > > On 2025-Aug-05, Nathan Bossart wrote: > >> I noticed that this function has a "namspace" parameter. The attached > >> patch adds the missing 'e'. > > > I have vague recollections of it being this way because of "namespace" > > being a C++ keyword. (commit is 3a5b77371522, but I don't have energy > > to look for the discussion right now.) > > Oh, duh -- if you try cpluspluscheck you'll find it's unhappy. > I didn't locate the discussion of "namspace" either, but I did > notice that de160e2c0 used "nameSpace" for the same purpose. > Maybe we should standardize on that? It looks less like a typo > than "namspace", for sure. WFM. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "No deja de ser humillante para una persona de ingenio saber que no hay tonto que no le pueda enseñar algo." (Jean B. Say)
Commits
-
Rename transformRelOptions()'s "namspace" parameter to "nameSpace".
- 35baa60cc7f3 19 (unreleased) landed
-
Make backend header files C++ safe
- de160e2c001f 9.0.0 cited