Re: More protocol.h replacements this time into walsender.c

Álvaro Herrera <alvherre@kurilemu.de>

From: Álvaro Herrera <alvherre@kurilemu.de>

To: Nathan Bossart <nathandbossart@gmail.com>

Cc: Dave Cramer <davecramer@gmail.com>, Jacob Champion <jacob.champion@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-08-04T12:05:04Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Expand usage of macros for protocol characters.
- 9ea3b6f751ab 19 (unreleased) landed
Rename XLogData protocol message to WALData
- 07684443b1e0 19 (unreleased) landed
Use PqMsg_* macros in walsender.c
- 37c7a7eeb6d1 19 (unreleased) landed

On 2025-Jul-25, Nathan Bossart wrote:

> On Fri, Jul 25, 2025 at 06:28:28AM -0400, Dave Cramer wrote:
> > On Fri, 25 Jul 2025 at 06:23, Álvaro Herrera <alvherre@kurilemu.de> wrote:
> >> Yeah, we could rename it, as in the attached.  It doesn't harm anything.
> > 
> > Consistency is good. If your patch were applied, then it would be
> > consistent to use WALData
> 
> +1

Okay, done, thanks.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/