Horton
Menu

Re: Log prefix missing for subscriber log messages received from publisher

Álvaro Herrera <alvherre@kurilemu.de>

View thread
From: Álvaro Herrera <alvherre@kurilemu.de>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, vignesh C <vignesh21@gmail.com>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-07-22T12:49:35Z
Lists: pgsql-hackers 
On 2025-Jul-22, Fujii Masao wrote:

> On Tue, Jul 22, 2025 at 8:47 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:

> > Oh yeah, I should have remembered this -- see commit 213c959a294d.  Feel
> > free to do away with the whole translation thing ... doesn't seem worth
> > spending more time on it.
> 
> Yes! The attached patch removes the translation marker and the
> gettext_noop() calls I recently added.

LGTM.

> > We should still remove all gettext_noop() markers in contrib :-)
> 
> You mean to remove gettext_noop() also from basic_archive.c?

Yes, it's useless and misleading.  Feel free to do it in the same commit ...

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"The ability of users to misuse tools is, of course, legendary" (David Steele)
https://postgr.es/m/11b38a96-6ded-4668-b772-40f992132797@pgmasters.net

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove translation marker from libpq-be-fe-helpers.h.

  2. Log remote NOTICE, WARNING, and similar messages using ereport().

  3. Remove translation markers from libpq-be-fe-helpers.h