Horton
Menu

Re: Log prefix missing for subscriber log messages received from publisher

Álvaro Herrera <alvherre@kurilemu.de>

View thread
From: Álvaro Herrera <alvherre@kurilemu.de>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, vignesh C <vignesh21@gmail.com>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-07-22T11:47:09Z
Lists: pgsql-hackers 
On 2025-Jul-22, Fujii Masao wrote:

> Is the issue caused by the use of _() in libpq-be-fe-helpers.h,
> instead of using gettext_noop() in dblink.c? At least in my test
> environment, the build error disappeared after applying
> the following change:
> 
> - errmsg_internal("%s: %.*s", _(prefix), len, message));
> + errmsg_internal("%s: %.*s", prefix, len, message));

Oh yeah, I should have remembered this -- see commit 213c959a294d.  Feel
free to do away with the whole translation thing ... doesn't seem worth
spending more time on it.

We should still remove all gettext_noop() markers in contrib :-)

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove translation marker from libpq-be-fe-helpers.h.

  2. Log remote NOTICE, WARNING, and similar messages using ereport().

  3. Remove translation markers from libpq-be-fe-helpers.h