Horton
Menu

Re: Log prefix missing for subscriber log messages received from publisher

Álvaro Herrera <alvherre@kurilemu.de>

View thread
From: Álvaro Herrera <alvherre@kurilemu.de>
To: vignesh C <vignesh21@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, Fujii Masao <masao.fujii@gmail.com>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-07-18T20:09:33Z
Lists: pgsql-hackers 
On 2025-Jul-18, vignesh C wrote:

> diff --git a/contrib/postgres_fdw/connection.c b/contrib/postgres_fdw/connection.c
> index 304f3c20f83..c1ce6f33436 100644
> --- a/contrib/postgres_fdw/connection.c
> +++ b/contrib/postgres_fdw/connection.c
> @@ -625,6 +625,9 @@ connect_pg_server(ForeignServer *server, UserMapping *user)
>  							server->servername),
>  					 errdetail_internal("%s", pchomp(PQerrorMessage(conn)))));
>  
> +		PQsetNoticeReceiver(conn, libpqsrv_notice_receiver,
> +							"received message via remote connection");
> +

These need to be:

    PQsetNoticeReceiver(conn, libpqsrv_notice_receiver,
                        gettext_noop("received message via remote connection"));

so that the strings are picked up by gettext.


Also, I don't see why there are three patches here instead of just one.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove translation marker from libpq-be-fe-helpers.h.

  2. Log remote NOTICE, WARNING, and similar messages using ereport().

  3. Remove translation markers from libpq-be-fe-helpers.h