Horton
Menu

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

Yugo Nagata <nagata@sraoss.co.jp>

View thread
From: Yugo Nagata <nagata@sraoss.co.jp>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>, Nathan Bossart <nathandbossart@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, <pgsql-hackers@postgresql.org>
Date: 2025-07-16T07:22:31Z
Lists: pgsql-hackers 
On Tue, 15 Jul 2025 19:07:16 +0900
Fujii Masao <masao.fujii@oss.nttdata.com> wrote:

> I've pushed the patch. Thanks!

Thank you!

> 
> >>> But perhaps this corner case doesn't really
> >>> need to be handled?
> >>
> >> Probably I failed to get your point here. Could you clarify what you meant?
> > 
> > I'm sorry for not explaining it clearly.
> > 
> > Currently, TO or FROM could be suggested immediately after FOREIGN SERVER, but
> > only when no foreign servers are defined. When foreign servers do exist,
> > their names are correctly suggested instead, as expected.
> > 
> > The patch fixed the behavior so that TO or FROM are not suggested after FOREIGN SERVER,
> > even when no foreign servers are defined. However, I've started to wonder if it's worth
> > fixing such a corner case. What do you think?
> 
> I think it's worth doing. This issue can lead to unexpected behavior
> and is something users might run into. If the fix were overly complex
> for a minor issue, it might not be justified. But that's not the case here.

Thank you for your explanation.
It makes sense to me.

Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. psql: Fix tab-completion after GRANT/REVOKE on LARGE OBJECT and FOREIGN SERVER.

  2. psql: Improve psql tab completion for GRANT/REVOKE on large objects.

  3. Extend ALTER DEFAULT PRIVILEGES to define default privileges for large objects.

  4. Convert tab-complete's long else-if chain to a switch statement.