Horton

Re: Get rid of WALBufMappingLock

Noah Misch <noah@leadboat.com>

View thread
From: Noah Misch <noah@leadboat.com>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Yura Sokolov <y.sokolov@postgrespro.ru>, Tomas Vondra <tomas@vondra.me>, Michael Paquier <michael@paquier.xyz>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2025-07-05T04:15:59Z
Lists: pgsql-hackers

Attachments

On Mon, Mar 31, 2025 at 09:18:30PM +0300, Alexander Korotkov wrote:
> I'm going to push the first patch ("nowalbuf") if no objections.

I completed a post-commit review of this patch.  I think the patch is correct.
 
I found some of the variable names and comments challenging, so I made the
attached local edits in the course of the review.  I don't know whether my
choices are better or just tailored to my biases.  If someone thinks this
would improve the tree, I can polish this and commit it.  Absent that,
consider these notes to myself and to other post-commit reviewers.