Re: Improve tab completion for COPY

Yugo Nagata <nagata@sraoss.co.jp>

From: Yugo Nagata <nagata@sraoss.co.jp>

To: torikoshia <torikoshia@oss.nttdata.com>

Cc: <sawada.mshk@gmail.com>, Pgsql Hackers <pgsql-hackers@postgresql.org>

Date: 2025-06-10T02:59:54Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix tab-completion for COPY and \copy options.
- f5a987c0e5f6 19 (unreleased) landed
- 765a4c94ccc8 18.0 landed
- c1c6169eb4f4 17.6 landed
- d69836b13c46 16.10 landed
- e3584e457db2 15.14 landed
- 0514616f0e28 14.19 landed
Add tab completion for REJECT_LIMIT option.
- b774ad493367 18.0 landed
Allow "COPY table TO" command to copy rows from materialized views.
- 534874fac0b3 18.0 cited
Add REJECT_LIMIT option to the COPY command.
- 4ac2a9beceb1 18.0 cited

On Tue, 10 Jun 2025 11:15:09 +0900
torikoshia <torikoshia@oss.nttdata.com> wrote:

> On 2025-06-03 17:58, Yugo Nagata wrote:
> > Thank you for updating the patch.
> > It looks good and I confirmed that this works as expected.
> 
> Thanks for your review!
> 
> BTW this is a small patch, but it does two things:
> 
> (1) adds tab completion support for the REJECT_LIMIT option, which was 
> introduced in v18
> (2) splits the tab completion logic between COPY FROM and COPY TO to 
> reflect their different options.
> 
> While maybe (2) should be postponed to v19 or later, I think it would be 
> better to include (1) in v18.
> So I’ve split them into separate patches accordingly.

I am not convinced whether (1) should be regarded as a v18-related oversight
or a new feature, but if this is a oversight, this should be added to the open
items list?

https://wiki.postgresql.org/wiki/PostgreSQL_18_Open_Items

Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>