Horton

Re: pg_dump does not dump domain not-null constraint's comments

Álvaro Herrera <alvherre@kurilemu.de>

View thread
From: Álvaro Herrera <alvherre@kurilemu.de>
To: jian he <jian.universality@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-05-07T14:56:01Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix pg_dump COMMENT dependency for separate domain constraints.

  2. pg_dump: include comments on not-null constraints on domains, too

  3. Fix dumping of comments on invalid constraints on domains

  4. Catalog domain not-null constraints

  5. In pg_dump, don't dump a stats object unless dumping underlying table.

  6. Enable CHECK constraints to be declared NOT VALID

Ooh, you know what?  I ran your the CREATE DOMAIN statement in your new
test and pg_dump'ed that, and as far as I can tell the _name_ of the
not-null constraint is not dumped either.  So it's not just the comment
that we're losing.  That's a separate bug, and probably needs to be
fixed first, although I'm not sure if that one is going to be
back-patchable.  Which means, I withdraw my earlier assessment that the
comment fix is back-patchable as a whole.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/