Re: Accounting for metapages in genericcostestimate()

On 2025-Apr-28, Tom Lane wrote:

> @@ -135,6 +141,7 @@ typedef struct
>  	double		numIndexTuples; /* number of leaf tuples visited */
>  	double		spc_random_page_cost;	/* relevant random_page_cost value */
>  	double		num_sa_scans;	/* # indexscans from ScalarArrayOpExprs */
> +	BlockNumber numNonLeafPages;	/* # of index pages that are not leafs */
>  } GenericCosts;

The idea you described seems quite reasonable, though I didn't review
the patch in detail.

I find the use of "leafs" as plural for "leaf" a bit strange ...
We already have uses of that word, but I wonder if they don't mostly
or exclusively come from non-native English speakers.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/