Unquoted file name in an error message

Kyotaro Horiguchi <horikyota.ntt@gmail.com>

From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Date: 2025-04-07T06:27:21Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Clean up error messages from 1495eff7bdb

Attachments

Hello.

While translating error messages related to pg_dumpall (1495eff7bdb),
I noticed that one message lacks double quotes around the file name:

  could not open map file: %s

Since this placeholder appears standalone and not embedded in a
sentence, I initially thought it might fall outside the usual
convention of quoting file names. However, a similar message added to
pg_restore does quote the file name, as in:

  could not open global.dat file: "%s"

So I believe this omission is unintentional.

The first of the attached patches adds double quotes around the file
name for consistency.

In addition, I noticed that pg_dump and pg_restore refer to map.dat
using different wording.  The second patch updates the message to
refer to "map.dat file" instead of "map file", for consistency with
how pg_restore refers to both "global.dat file" and "map.dat file"
explicitly.


I noticed that there are other messages in other files that refer to
file names without quotes as well, but I'm not addressing those here.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center