Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Quote filename in error message

  2. libpq: Add support for dumping SSL key material to file

  1. Quote-less file names in error messages

    Kyotaro Horiguchi <horikyota.ntt@gmail.com> — 2025-04-04T03:03:28Z

    Hello,

The recent commit 2da74d8d640 added the following new messages:

+		libpq_append_conn_error(conn, "could not open ssl keylog file %s: %s",
+		libpq_append_conn_error(conn, "could not write to ssl keylog file %s: %s

However, I believe our convention is to quote file names in such messages.

The attached patch 0001 fixes this issue.

While working on this, I found a few other instances of the same
issue:

- A WARNING message in `fd.c` seems worth fixing (0002).

- Two DEBUG2 messages in `xlog.c` seem less important to fix (0003).

- I don't think it's worth bothering with those in developer tools (0004).

Please find the attached patches.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

  2. Re: Quote-less file names in error messages

    Daniel Gustafsson <daniel@yesql.se> — 2025-04-04T07:40:01Z

    > On 4 Apr 2025, at 05:03, Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote:
> 
> Hello,
> 
> The recent commit 2da74d8d640 added the following new messages:
> 
> + libpq_append_conn_error(conn, "could not open ssl keylog file %s: %s",
> + libpq_append_conn_error(conn, "could not write to ssl keylog file %s: %s
> 
> However, I believe our convention is to quote file names in such messages.

Thanks for the report, I'll get it fixed.

> - A WARNING message in `fd.c` seems worth fixing (0002).

Thi is an elog() and not an error intended to be common for users, so I'm not
sure it's worth the churn really as it's been there since 2012.  Changing it
might introduce conflicts in backpatching for little gain.

> - Two DEBUG2 messages in `xlog.c` seem less important to fix (0003).
> 
> - I don't think it's worth bothering with those in developer tools (0004).

Agreed.

--
Daniel Gustafsson