Re: confusing / inefficient "need_transcoding" handling in copy
Sutou Kouhei <kou@clear-code.com>
From: Sutou Kouhei <kou@clear-code.com>
To: michael@paquier.xyz
Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, pgsql-hackers@postgresql.org,
ishii@sraoss.co.jp
Date: 2024-12-16T02:39:58Z
Lists: pgsql-hackers
Hi, In <Z1-PjE6KPimF8w55@paquier.xyz> "Re: confusing / inefficient "need_transcoding" handling in copy" on Mon, 16 Dec 2024 11:25:16 +0900, Michael Paquier <michael@paquier.xyz> wrote: > On Sat, Dec 14, 2024 at 04:46:57PM +0900, Michael Paquier wrote: >> Note that using "test" as table name for the tests is not a good idea, >> as this could very likely conflict with some concurrent activity. I >> would also add two RESET queries to remove the dependency to >> client_encoding once the test has no need to rely on it. No need to >> send a new patch for all that, just noticing in passing. > > I got some time to look again at this one. Applied with the tweaks > for the table name and the two RESET queries. Thanks! I'll use better table name next time. Thanks, -- kou
Commits
-
Add some tests for encoding conversion in COPY TO/FROM
- 3ad8b840ce8b 18.0 landed
-
Improve COPY TO performance when server and client encodings match
- b619852086ed 17.0 landed