Horton

Re: Potential ABI breakage in upcoming minor releases

Noah Misch <noah@leadboat.com>

View thread
From: Noah Misch <noah@leadboat.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, "David E. Wheeler" <david@justatheory.com>, Aleksander Alekseev <aleksander@timescale.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Marco Slot <marco.slot@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Christoph Berg <myon@debian.org>, Pavan Deolasee <pavan.deolasee@gmail.com>
Date: 2024-12-04T21:00:56Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Undo unintentional ABI break in struct ResultRelInfo.

  2. For inplace update durability, make heap_update() callers wait.

  3. Fix btmarkpos/btrestrpos array key wraparound bug.

  4. Fix calculation of which GENERATED columns need to be updated.

On Wed, Dec 04, 2024 at 08:29:57PM +0100, Peter Eisentraut wrote:
> On 29.11.24 21:39, Noah Misch wrote:
> > > I remembered where that's documented:
> > > 
> > > https://wiki.postgresql.org/wiki/Committing_checklist#Maintaining_ABI_compatibility_while_backpatching
> > I'd say the source tree's <sect2 id="xfunc-api-abi-stability-guidance">, which
> > David Wheeler mentioned, is authoritative.  It currently matches
> > postgr.es/c/e54a42a.  Let's update both or change that wiki heading to point
> > to the authoritative doc section.

I hereby revoke the last sentence and replace it with "Let's update both in
some way."  The revoked sentence and its replacement are probably the least
important thing I wrote in that mail.

> I don't know if this proposing to merge the text in the wiki into the docs?

The revoked proposal wasn't that specific.  1576843.1732586210@sss.pgh.pa.us
offered some wiki changes mostly about struct fields.  Doc section
xfunc-api-abi-stability-guidance also writes about struct fields.
Specifically, it discusses "squeezing a new field into padding space or
appending it to the end of a struct".  If we change the wiki about struct
fields, we should not leave that quote unchanged.  I no longer wish to affect
how we allocate text to the wiki vs. xfunc-api-abi-stability-guidance.