Horton
Menu

Re: Fix array access (src/bin/pg_dump/pg_dump.c)

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Ranier Vilela <ranier.vf@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2024-11-12T19:11:07Z
Lists: pgsql-hackers 
On 2024-Nov-12, Ranier Vilela wrote:

> Per Coverity.
> 
> The function *determineNotNullFlags* has a little oversight.
> The struct field *notnull_islocal* is an array.
> 
> I think this is a simple typo.
> Fix using array notation access.

Yeah, thanks, I had been made aware of this bug.  Before fixing I'd like
to construct a test case that tickles that code, because it's currently
uncovered  *shudder*

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Find a bug in a program, and fix it, and the program will work today.
Show the program how to find and fix a bug, and the program
will work forever" (Oliver Silfridge)

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix invalid boolean if-test