Horton

Thread

Commits

  1. Remove unnecessary backslash from CopyFrom() code.

  2. Add REJECT_LIMIT option to the COPY command.

  1. Remove a unnecessary backslash in CopyFrom

    Yugo Nagata <nagata@sraoss.co.jp> — 2024-11-12T02:46:09Z

    Hi,

I found a unnecessary backslash in CopyFrom().

            if (cstate->opts.reject_limit > 0 && \
                cstate->num_errors > cstate->opts.reject_limit)

It can be removed because this is not in a macro.
I've attached a patch.

Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>

  2. Re: Remove a unnecessary backslash in CopyFrom

    Tender Wang <tndrwang@gmail.com> — 2024-11-12T02:58:50Z

    Yugo Nagata <nagata@sraoss.co.jp> 于2024年11月12日周二 10:46写道：

> Hi,
>
> I found a unnecessary backslash in CopyFrom().
>
>             if (cstate->opts.reject_limit > 0 && \
>                 cstate->num_errors > cstate->opts.reject_limit)
>
> It can be removed because this is not in a macro.
> I've attached a patch.
>

Yeah, agree. The patch LGTM.

-- 
Thanks,
Tender Wang

  3. Re: Remove a unnecessary backslash in CopyFrom

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2024-11-12T03:31:14Z

    
On 2024/11/12 11:58, Tender Wang wrote:
> 
> 
> Yugo Nagata <nagata@sraoss.co.jp <mailto:nagata@sraoss.co.jp>> 于2024年11月12日周二 10:46写道：
> 
>     Hi,
> 
>     I found a unnecessary backslash in CopyFrom().
> 
>                  if (cstate->opts.reject_limit > 0 && \
>                      cstate->num_errors > cstate->opts.reject_limit)
> 
>     It can be removed because this is not in a macro.
>     I've attached a patch.
> 
> 
> Yeah, agree. The patch LGTM.

Thanks for the report and patch! This is a mistake in commit 4ac2a9bece.
I'll commit the patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  4. Re: Remove a unnecessary backslash in CopyFrom

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2024-11-15T17:08:43Z

    
On 2024/11/12 12:31, Fujii Masao wrote:
> 
> 
> On 2024/11/12 11:58, Tender Wang wrote:
>>
>>
>> Yugo Nagata <nagata@sraoss.co.jp <mailto:nagata@sraoss.co.jp>> 于2024年11月12日周二 10:46写道：
>>
>>     Hi,
>>
>>     I found a unnecessary backslash in CopyFrom().
>>
>>                  if (cstate->opts.reject_limit > 0 && \
>>                      cstate->num_errors > cstate->opts.reject_limit)
>>
>>     It can be removed because this is not in a macro.
>>     I've attached a patch.
>>
>>
>> Yeah, agree. The patch LGTM.
> 
> Thanks for the report and patch! This is a mistake in commit 4ac2a9bece.
> I'll commit the patch.

Pushed. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION