Horton

Re: Fix for Extra Parenthesis in pgbench progress message

Tatsuo Ishii <ishii@postgresql.org>

View thread View on postgr.es
From: Tatsuo Ishii <ishii@postgresql.org>
To: btogiwarayuushi@oss.nttdata.com
Cc: pgsql-hackers@postgresql.org
Date: 2024-11-02T11:43:10Z
Lists: pgsql-hackers 
> Hi,
> 
> I noticed an issue in the pgbench progress message where an extra
> closing parenthesis )) appears, as shown below:
> 
> 7000000 of 10000000 tuples (70%) of pgbench_accounts done (elapsed
> 19.75 s, remaining 8.46 s))

Yeah, annoying.

> This occurs when running commands like pgbench -i -s100 and is caused
> by leftover characters when using \r with fprintf. I made a patch to
> address this by adding extra spaces before \r, which clears any
> remaining characters. While effective, I recognize this solution may
> not be the most sophisticated.

The patch works perfectly for the case that there is one extra brace
as shown in your example. However I think it will not work if there
are two or more extra braces.

Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

Commits

  1. Fix pgbench performance issue induced by commit af35fe501.

  2. pgbench: Ensure previous progress message is fully cleared when updating.