Horton

Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails

Jehan-Guillaume de Rorthais <jgdr@dalibo.com>

View thread View on postgr.es
From: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tender Wang <tndrwang@gmail.com>, Junwang Zhao <zhjwpku@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Alexander Lakhin <exclusion@gmail.com>, Guillaume Lelarge <guillaume@lelarge.info>, Michael Paquier <michael@paquier.xyz>
Date: 2024-10-23T08:01:54Z
Lists: pgsql-hackers 
On Tue, 22 Oct 2024 16:32:33 +0200
Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:

> On 2024-Oct-22, Jehan-Guillaume de Rorthais wrote:
> 
> > On Fri, 18 Oct 2024 16:50:59 +0200
> > Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:  
> 
> > > For branch 14, I opted to make it delete the constraints on detach.
> > > This isn't ideal but unless somebody wants to spend a lot more time on
> > > this, it seems the best we can do.  Leaving broken constraints around
> > > seems worse.   
> > 
> > Keep that in mind, and move ahead to the next level: self-FK on partitioned
> > table! ;-)
> > 
> > https://www.postgresql.org/message-id/flat/20230707175859.17c91538%40karst#0dc7b8afd8b780899021bbb075598250  
> 
> Yeah.  I pushed these patches finally, thanks!

Great! Many thanks Alvaro and Tender for your work on this issue.

Commits

  1. Fix some more bugs in foreign keys connecting partitioned tables

  2. Restructure foreign key handling code for ATTACH/DETACH

  3. Create foreign key triggers in partitioned tables too