Re: Remove unlogged materialized view persistence handling

Yugo Nagata <nagata@sraoss.co.jp>

From: Yugo Nagata <nagata@sraoss.co.jp>
To: px shi <spxlyy123@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2024-10-11T03:27:13Z
Lists: pgsql-hackers
On Fri, 11 Oct 2024 10:35:17 +0800
px shi <spxlyy123@gmail.com> wrote:

> Hi,
> 
> Since materialized views do not support the unlogged type, I think that we
> should remove the logic and handling related to unlogged. Therefore, I have
> submitted a patch.

+1

Materialized view is introduced by 3bf3ab8c563 and at that UNLOGGED was
allowed, and it is disallowed by another commit 3223b25ff73. However,
it seems that the tab-complement is missed to fixed.

The Assert for RELKIND_MATVIEW in heapam_hander.c was introduced in d25f519107b
after that, but I think it can be also removed.

Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>



Commits

  1. Remove unused code for unlogged materialized views.

  2. Disallow unlogged materialized views.