Horton

Re: Psql meta-command conninfo+

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Maiquel Grassi <grassi@hotmail.com.br>
Cc: "Imseih (AWS), Sami" <simseih@amazon.com>, Nathan Bossart <nathandbossart@gmail.com>, Jim Jones <jim.jones@uni-muenster.de>, Pavel Luzanov <p.luzanov@postgrespro.ru>, Erik Wienhold <ewie@ewie.name>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2024-03-30T17:09:19Z
Lists: pgsql-hackers 
Hello,

Note that, in the patch as posted, the column names are not
translatable.  In order to be translatable, the code needs to do
something like

appendPQExpBuffer(&buf,
		"  NULL AS \"%s\",\n"
		"  NULL AS \"%s\",\n"
		"  NULL AS \"%s\",\n"
		"  NULL AS \"%s\",\n",
		_("SSL Connection"),
		_("SSL Protocol"),
		_("SSL Cipher"),
		_("SSL Compression"));

instead of 

       appendPQExpBuffer(&buf,
                         "  NULL AS \"SSL Connection\",\n"
                         "  NULL AS \"SSL Protocol\",\n"
                         "  NULL AS \"SSL Cipher\",\n"
                         "  NULL AS \"SSL Compression\",\n");


Please list me as reviewer for this patch, as I provided significant
guidance before it was even posted.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/

Commits

  1. psql: Change new \conninfo to use SSL instead of TLS

  2. Change \conninfo to use tabular format

  3. Update extension lookup routines to use the syscache

  4. Improve COPY TO performance when server and client encodings match

  5. doc: Remove superfluous bracket in synopsis

  6. Remove psql support for server versions preceding 9.2.