Re: DOCS: add helpful partitioning links
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Robert Treat <rob@xzilla.net>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-03-28T17:52:29Z
Lists: pgsql-hackers
Attachments
- with-extra-para.png (image/png)
- no-extra-para.png (image/png)
- 0001-doc-Improve-Partition-Maintenance-section.patch (text/x-diff)
On 2024-Mar-28, Ashutosh Bapat wrote: > LGTM. > > The commitfest entry is marked as RFC already. > > Thanks for taking care of the comments. Thanks for reviewing. I noticed a typo "seperate", fixed here. Also, I noticed that Robert added an empty line which looks in the source like he's breaking the paragraph -- but because he didn't add a closing </para> and an opening <para> to the next one, there's no actual new paragraph in the HTML output. My first instinct was to add those. However, upon reading the text, I noticed that the previous paragraph ends without offering an example, and then we attach the example to the paragraph that takes about CREATE TABLE LIKE showing both techniques, which seemed a bit odd. So instead I joined both paragraphs back together. I'm unsure which one looks better. Which one do you vote for? -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "No hay ausente sin culpa ni presente sin disculpa" (Prov. francés)
Commits
-
doc: Improve "Partition Maintenance" section
- 056c56574274 17.0 landed