Re: Make attstattarget nullable

Nathan Bossart <nathandbossart@gmail.com>

From: Nathan Bossart <nathandbossart@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-03-17T19:29:27Z
Lists: pgsql-hackers

Attachments

On Sun, Mar 17, 2024 at 01:51:39PM +0100, Peter Eisentraut wrote:
> I have committed this patch series.  Thanks.

My compiler is worried that "newtarget" might be getting used
uninitialized.  AFAICT there's no actual risk here, so I think initializing
it to 0 is sufficient.  I'll commit the attached patch shortly.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Commits

  1. Initialize variables to placate compiler.

  2. Add attstattarget to FormExtraData_pg_attribute

  3. Generalize handling of nullable pg_attribute columns in DDL

  4. Make stxstattarget nullable

  5. Make attstattarget nullable