Horton

Re: RangeTblEntry.inh vs. RTE_SUBQUERY

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>, Dean Rasheed <dean.a.rasheed@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-02-29T19:07:20Z
Lists: pgsql-hackers 
On 2024-Feb-29, Tom Lane wrote:

> I agree that perminfoindex seems to have suffered from add-at-the-end
> syndrome, and if we do touch the field order you made an improvement
> there.  (BTW, who thought they needn't bother with a comment for
> perminfoindex?)

There is a comment for it, or at least a61b1f74823c added one, though
not immediately adjacent.  I do see that it's now further away than it
was.  Perhaps we could add /* index of RTEPermissionInfo entry, or 0 */
to the line.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"The ability of users to misuse tools is, of course, legendary" (David Steele)
https://postgr.es/m/11b38a96-6ded-4668-b772-40f992132797@pgmasters.net

Commits

  1. Fix description and grouping of RangeTblEntry.inh

  2. Improve field order in RangeTblEntry