Re: Running the fdw test from the terminal crashes into the core-dump
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alena Rybakina <a.rybakina@postgrespro.ru>, Pgsql Hackers <pgsql-hackers@postgresql.org>,
Amit Langote <amitlangote09@gmail.com>
Date: 2024-02-23T22:03:01Z
Lists: pgsql-hackers
On 2024-Feb-22, Tom Lane wrote: > Alvaro Herrera <alvherre@alvh.no-ip.org> writes: > > I propose the attached. (Extra context so that the full paragraph can > > be read from the comfort of your email program.) > > This reads awkwardly to me. I think it'd be better to construct it > so that DO NOTHING's requirement is stated exactly parallel to the other > three clause types, more or less as attached. Sure, that works. > BTW, if you read it without paying attention to markup, you'll notice > that we are saying things like > > If you specify an insert action, you must have the INSERT > privilege on the target_table_name. > > which is fairly nonsensical: we don't define privileges on the name > of something. Hmm, you're right, this is not strictly correct. > While I've not done anything about that here, I wonder if we shouldn't > just write "privilege on the target table" without any special markup. That would work for me. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
Commits
-
Revise MERGE documentation
- c4bd6ff57c9a 16.3 landed
- 6979ea2638a5 17.0 landed
- 172d7f7e666e 15.7 landed
-
MERGE ... DO NOTHING: require SELECT privileges
- a3f5d2056ceb 16.3 landed
- 90ad85db6a4e 15.7 landed
- 4989ce72644b 17.0 landed
-
Rework query relation permission checking
- a61b1f74823c 16.0 cited