Re: Should we remove -Wdeclaration-after-statement?

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Jelte Fennema-Nio <postgres@jeltef.nl>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Andrew Dunstan <andrew@dunslane.net>, "ranier.vf@gmail.com" <ranier.vf@gmail.com>, chap@anastigmatix.net

Date: 2024-01-29T20:38:50Z

Lists: pgsql-hackers

Hi,

On 2024-01-29 15:01:06 -0500, Robert Haas wrote:
> And it still baffles me why we allow everyone to pick their own system for
> capitalizing identifiers out of a hat, without even insisting on consistency
> from one end of the same identifier to the other.

Yes. Please. I hate some capitalization/underscore styles, but I hate spending
time feeling out which capitalization style I should use so much more.  Let's
at least define some minimal naming guidelines for new code.

Personally I like under_score_style for functions and variables and CamelCase
for types.

Greetings,

Andres Freund