Horton

Re: Should we remove -Wdeclaration-after-statement?

Nathan Bossart <nathandbossart@gmail.com>

View thread
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>, Andrew Dunstan <andrew@dunslane.net>, "ranier.vf@gmail.com" <ranier.vf@gmail.com>, chap@anastigmatix.net
Date: 2024-01-29T15:37:57Z
Lists: pgsql-hackers 
On Mon, Jan 29, 2024 at 10:23:38AM -0500, Tom Lane wrote:
> Jelte Fennema-Nio <postgres@jeltef.nl> writes:
>> I feel like this is the type of change where there's not much
>> discussion to be had. And the only way to resolve it is to use some
>> voting to gauge community opinion.
> 
>> So my suggestion is for people to respond with -1, -0.5, +-0, +0.5, or
>> +1 to indicate support against/for the change.
> 
>> I'll start: +1
> 
> [ shrug... ]  -1 here.

-1 here, too.  I don't think one style is enormously better than the other,
but I do like having the declarations in a predictable location.  I
actually find the alternative less readable, but that could just be because
I spend so much time looking at Postgres code.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com