Horton

Re: Remove redundant HandleWalWriterInterrupts()

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-01-24T19:40:19Z
Lists: pgsql-hackers 
On Wed, Jan 24, 2024 at 07:30:17PM +0530, Bharath Rupireddy wrote:
> On Wed, Jan 24, 2024 at 5:50 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>> Because of commit 1bdd54e662, the code of HandleWalWriterInterrupts()
>> became the same as HandleMainLoopInterrupts(). So I'd like to propose to
>> remove HandleWalWriterInterrupts() and make walwriter use
>> HandleMainLoopInterrupts() instead for improved code simplicity. Thought?
>>
>> Patch attached.
> 
> Nice catch. Indeed they both are the same after commit 1bdd54e662. The
> patch LGTM.

LGTM, too.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Commits

  1. Remove redundant HandleWalWriterInterrupts().

  2. Remove redundant call to pgstat_report_wal()