Horton

Re: verify predefined LWLocks have entries in wait_event_names.txt

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Michael Paquier <michael@paquier.xyz>
Date: 2024-01-06T16:18:52Z
Lists: pgsql-hackers

Attachments

On Sat, Jan 06, 2024 at 09:03:52AM +0000, Bertrand Drouvot wrote:
> Sorry, I missed this in my first review, but instead of:
> 
> -  input: files('../../backend/storage/lmgr/lwlocknames.txt'),
> +  input: [files('../../backend/storage/lmgr/lwlocknames.txt'), files('../../backend/utils/activity/wait_event_names.txt')],
> 
> what about?
> 
>   input: files(
>     '../../backend/storage/lmgr/lwlocknames.txt',
>     '../../backend/utils/activity/wait_event_names.txt',
>   ),
> 
> It's done that way in doc/src/sgml/meson.build for example.

I fixed this in v4.

> Except for the above, the patch looks good to me.

Thanks for reviewing!

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Commits

  1. Cross-check lists of predefined LWLocks.

  2. Remove Lock suffix from WALSummarizerLock in wait_event_names.txt

  3. Drop the redundant "Lock" suffix from LWLock wait event names.