Re: Little cleanup of ShmemInit function names
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Andreas Karlsson <andreas@proxel.se>,
"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2024-08-29T01:06:45Z
Lists: pgsql-hackers
On 2024-Aug-28, Tom Lane wrote: > Heikki Linnakangas <hlinnaka@iki.fi> writes: > > Hmm, I don't see the issue. It's an uncommon sentence structure, but it > > was there before this patch, and it's correct AFAICS. If you grep for > > "which see ", you'll find some more examples of that. > > I didn't check the git history for this particular line, but at least > some of those examples are mine. I'm pretty certain it's good English. As a non-native speaker, I'm always grateful for examples of unusual grammatical constructs. They have given me many more opportunities for growth than if all comments were restricted to simple English. I have had many a chance to visit english.stackexchange.net on account of something I read in pgsql lists or code comments. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
Commits
-
Rename some shared memory initialization routines
- 478846e7688c 18.0 landed
-
Refactor lock manager initialization to make it a bit less special
- fbce7dfc77ea 18.0 landed