Horton

Re: Test 041_checkpoint_at_promote.pl faild in installcheck due to missing injection_points

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, Maxim Orlov <orlovmg@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-08-20T16:30:35Z
Lists: pgsql-hackers 
On 2024-Aug-20, Tom Lane wrote:

> We do, however, need to preserve the property that installcheck
> works after install-world.  I'm starting to think that maybe
> the 041 test should be hacked to silently skip if it doesn't
> find injection_points available.

Yeah, I like this option.  Injection points require to be explicitly
enabled in configure, so skipping that test when injection_points can't
be found seems reasonable.

This also suggests that EXTRA_INSTALL should have injection_points only
when the option is enabled.

I've been curious about what exactly does this Makefile line
  export enable_injection_points enable_injection_points
achieve.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

Commits

  1. Check availability of module injection_points in TAP tests

  2. Avoid installcheck failure in TAP tests using injection_points

  3. Simplify makefiles exporting twice enable_injection_points