Horton

Thread

Commits

  1. Fix copy/paste mistake in comment

  1. Fix a comment on PQcancelErrorMessage

    Yugo Nagata <nagata@sraoss.co.jp> — 2024-07-04T04:46:38Z

    Hi,

Attached is a small patch to fix a comment on PQcancelErrorMessage.

It was accidentally "Get the socket of the cancel connection."
I rewrote it to "Returns the error message most recently generated
by an operation on the cancel connection."

Regards,
Yugo Nagata

-- 
Yugo NAGATA <nagata@sraoss.co.jp>

  2. Re: Fix a comment on PQcancelErrorMessage

    Jelte Fennema-Nio <postgres@jeltef.nl> — 2024-07-04T09:06:03Z

    On Thu, 4 Jul 2024 at 06:46, Yugo NAGATA <nagata@sraoss.co.jp> wrote:
> Attached is a small patch to fix a comment on PQcancelErrorMessage.

Oops, copy paste mistake on my part I guess. New comment LGTM

  3. Re: Fix a comment on PQcancelErrorMessage

    Yugo Nagata <nagata@sraoss.co.jp> — 2024-07-04T10:39:31Z

    On Thu, 4 Jul 2024 11:06:03 +0200
Jelte Fennema-Nio <postgres@jeltef.nl> wrote:

> On Thu, 4 Jul 2024 at 06:46, Yugo NAGATA <nagata@sraoss.co.jp> wrote:
> > Attached is a small patch to fix a comment on PQcancelErrorMessage.
> 
> Oops, copy paste mistake on my part I guess. New comment LGTM

Thank you for your comments.

I made a trivial change that fixes the line break position in keeping with
the surrounding comments.

Regards,
Yugo Nagata


-- 
Yugo NAGATA <nagata@sraoss.co.jp>

  4. Re: Fix a comment on PQcancelErrorMessage

    Alvaro Herrera <alvherre@alvh.no-ip.org> — 2024-07-04T12:00:18Z

    On 2024-Jul-04, Yugo NAGATA wrote:

> On Thu, 4 Jul 2024 11:06:03 +0200
> Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
> 
> > On Thu, 4 Jul 2024 at 06:46, Yugo NAGATA <nagata@sraoss.co.jp> wrote:
> > > Attached is a small patch to fix a comment on PQcancelErrorMessage.
> > 
> > Oops, copy paste mistake on my part I guess. New comment LGTM
> 
> Thank you for your comments.
> 
> I made a trivial change that fixes the line break position in keeping with
> the surrounding comments.

Ugh, mea culpa for failing to notice -- thank you, pushed.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Learn about compilers. Then everything looks like either a compiler or
a database, and now you have two problems but one of them is fun."
            https://twitter.com/thingskatedid/status/1456027786158776329