Re: Remove distprep
Noah Misch <noah@leadboat.com>
From: Noah Misch <noah@leadboat.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Michael Paquier <michael@paquier.xyz>, pgsql-hackers <pgsql-hackers@postgresql.org>, Andres Freund <andres@anarazel.de>
Date: 2024-06-16T19:34:48Z
Lists: pgsql-hackers
On Thu, Oct 05, 2023 at 05:46:46PM +0200, Peter Eisentraut wrote: > --- a/src/backend/Makefile > +++ b/src/backend/Makefile > $(top_builddir)/src/include/storage/lwlocknames.h: storage/lmgr/lwlocknames.h > - prereqdir=`cd '$(dir $<)' >/dev/null && pwd` && \ > - cd '$(dir $@)' && rm -f $(notdir $@) && \ > - $(LN_S) "$$prereqdir/$(notdir $<)" . > + rm -f '$@' > + $(LN_S) ../../backend/$< '$@' > > $(top_builddir)/src/include/utils/wait_event_types.h: utils/activity/wait_event_types.h > - prereqdir=`cd '$(dir $<)' >/dev/null && pwd` && \ > - cd '$(dir $@)' && rm -f $(notdir $@) && \ > - $(LN_S) "$$prereqdir/$(notdir $<)" . > + rm -f '$@' > + $(LN_S) ../../backend/$< '$@' These broke the https://www.postgresql.org/docs/17/installation-platform-notes.html#INSTALLATION-NOTES-MINGW build, where LN_S='cp -pR'. On other platforms, "make LN_S='cp -pR'" reproduces this. Reverting the above lines fixes things. The buildfarm has no coverage for that build scenario (fairywren uses Meson).
Commits
-
Fix make build on MinGW
- 58445651dbc6 17.0 landed
-
Stop generating plain-text INSTALL instructions.
- e2b73f4a4de6 17.0 landed
-
Remove distprep
- 721856ff24b3 17.0 landed